libxl: suspend: common suspend callbacks take rc
authorIan Jackson <ian.jackson@eu.citrix.com>
Fri, 20 Dec 2013 12:43:17 +0000 (12:43 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 26 Jun 2015 15:53:50 +0000 (16:53 +0100)
commit9cceade9fed78425019ffaf192b1254f50f2d79c
tree3890800b70d06ac4eea63b4b384b086d96eab60f
parent52d860d78fd38f5a0cedff771d66313b42e8b801
libxl: suspend: common suspend callbacks take rc

Change the following functions to take a libxl error code rather than
a boolean "ok" value, and translate that value to the boolean expected
by libxc at the last moment:
  domain_suspend_callback_common_done        } dss->callback_common_done
  remus_domain_suspend_callback_common_done  }
  domain_suspend_common_done

Also, abolish domain_suspend_common_failed as
domain_suspend_common_done can easily do its job and the call sites
now have to supply the right rc value anyway.

In domain_suspend_common_guest_suspended, change "ret" to "rc"
as it contains a libxl error code.

There is no functional change in this patch: the proper rc value now
propagates further, but is still eventually smashed to a boolean.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
v2: Fix a leftover comment referring to domain_suspend_common_failed
tools/libxl/libxl_dom.c